update ApplyMetadata doc #10510
Merged
update ApplyMetadata doc #10510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now this PR raises a point here. If these unmanaged APIs are also available in Core, we need to do two things here: Who would be a good person to talk about this? |
|
Pinging @noahfalk here too. We can take this offline but wanted to get the conversation going. |
|
Noah and I are probably the best people to talk to about this. Adding @dotnet/dotnet-diag for visibility to the rest of the team. |
|
Ok, thanks @davmason! I'll start a thread about this offline. Merging the PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have a PR open at dotnet/coreclr#22617 to relax
ICorProfilerInfo7::ApplyMetadatato allow the definition ofTypeDefs andMethodDefs.This PR updates the documentation to reflect that.